[
https://issues.apache.org/jira/browse/LUCENE-9316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084600#comment-17084600
]
Dawid Weiss commented on LUCENE-9316:
-------------------------------------
The way I always thought it should work would be for {{precommit}} to run a
subset of all the checks. This subset should be composed of tasks that are
fairly fast so that people can (and should) run them before they commit stuff.
My personal opinion at the moment is that precommit tries to run too much (it
shouldn't take longer than a two minutes on an average hardware).
A {{gradlew check}} runs full validation: everything, including tests. Adding
{{ -x test}} is a way of excluding tests from that set (which I know is
tempting since tests run for so long).
Another difference is that "precommit" is a top-level task we added that
collects other things from subprojects while "check" is per-project. So, in
theory, if you know you only worked on {{:solr:core}}, you could run {{-p
solr/core check}} and this would run a full set of validation tasks for that
project only.
> Incorporate all :precommit tasks into :check
> --------------------------------------------
>
> Key: LUCENE-9316
> URL: https://issues.apache.org/jira/browse/LUCENE-9316
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: master (9.0)
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
