dnhatn commented on a change in pull request #1427: LUCENE-9304: Fix
IW#getMaxCompletedSequenceNumber()
URL: https://github.com/apache/lucene-solr/pull/1427#discussion_r407857559
##########
File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java
##########
@@ -3949,4 +3950,69 @@ public void testRandomOperationsWithSoftDeletes()
throws Exception {
}
}
}
+
+ public void testMaxCompletedSequenceNumber() throws IOException,
InterruptedException {
+ try (Directory dir = newDirectory();
+ IndexWriter writer = new IndexWriter(dir, new IndexWriterConfig());) {
+ assertEquals(1, writer.addDocument(new Document()));
+ assertEquals(2, writer.updateDocument(new Term("foo", "bar"), new
Document()));
+ writer.flushNextBuffer();
+ assertEquals(3, writer.commit());
+ assertEquals(4, writer.addDocument(new Document()));
+ assertEquals(4, writer.getMaxCompletedSequenceNumber());
+ // commit moves seqNo by 2 since there is one DWPT that could still be
in-flight
+ assertEquals(6, writer.commit());
+ assertEquals(6, writer.getMaxCompletedSequenceNumber());
+ assertEquals(7, writer.addDocument(new Document()));
+ writer.getReader().close();
+ // getReader moves seqNo by 2 since there is one DWPT that could still
be in-flight
+ assertEquals(9, writer.getMaxCompletedSequenceNumber());
+ }
+ try (Directory dir = newDirectory();
+ IndexWriter writer = new IndexWriter(dir, newIndexWriterConfig());
+ SearcherManager manager = new SearcherManager(writer, new
SearcherFactory())) {
+ CountDownLatch start = new CountDownLatch(1);
+ int numDocs = 100 + random().nextInt(500);
+ AtomicLong maxCompletedSeqID = new AtomicLong(-1);
+ Thread[] threads = new Thread[2 + random().nextInt(2)];
+ for (int i = 0; i < threads.length; i++) {
+ int idx = i;
+ threads[i] = new Thread(() -> {
+ try {
+ start.await();
+ for (int j = 0; j < numDocs; j++) {
+ Document doc = new Document();
+ String id = idx +"-"+j;
+ doc.add(new StringField("id", id, Field.Store.NO));
+ long seqNo = writer.addDocument(doc);
+ if (maxCompletedSeqID.get() < seqNo) {
+ long maxCompletedSequenceNumber =
writer.getMaxCompletedSequenceNumber();
+ manager.maybeRefreshBlocking();
+ long prevValue;
+ while ((prevValue = maxCompletedSeqID.get()) <
maxCompletedSequenceNumber) {
Review comment:
maybe use `updateAndGet` instead of loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
