[ https://issues.apache.org/jira/browse/LUCENE-9298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17080893#comment-17080893 ]
ASF subversion and git services commented on LUCENE-9298: --------------------------------------------------------- Commit 1eef78d5f89eac07fca23df9a35cf016f420112d in lucene-solr's branch refs/heads/branch_8x from Nhat Nguyen [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=1eef78d ] LUCENE-9298: Fix TestBufferedUpdates This test failed on Elastic CI because we did not add any term in the loop. This commit ensures that we always add at least one docId, term and query in the test. > Improve RAM accounting in BufferedUpdates when deleted doc IDs and terms are > cleared > ------------------------------------------------------------------------------------ > > Key: LUCENE-9298 > URL: https://issues.apache.org/jira/browse/LUCENE-9298 > Project: Lucene - Core > Issue Type: Bug > Affects Versions: 8.5 > Reporter: yubinglei > Assignee: Simon Willnauer > Priority: Minor > Labels: easyfix, newbie, pull-request-available > Fix For: master (9.0), 8.6 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > As mentioned in this > [https://github.com/apache/lucene-solr/pull/513#discussion_r399131681] > the method clearDeletedDocIds in BufferedUpdates.java has a bug, it can't > reset bytesUsed correctly > {code:java} > void clearDeletedDocIds() { > deleteDocIDs.clear(); > bytesUsed.addAndGet(-deleteDocIDs.size() * > BufferedUpdates.BYTES_PER_DEL_DOCID); > } > {code} > > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org