[
https://issues.apache.org/jira/browse/SOLR-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17079446#comment-17079446
]
Christine Poerschke edited comment on SOLR-14400 at 4/9/20, 3:01 PM:
---------------------------------------------------------------------
Attached patch proposes these two changes:
* DirectUpdateHandler2 no longer needs to override getSolrMetricsContext: at
the time of SOLR-13866 the override was needed but subsequently SOLR-13858
removed DirectUpdateHandler2's own solrMetricsContext and added a
solrMetricsContext in the parent UpdateHandler class instead.
* SuggestComponent currently has its own metricsContext but after the
SOLR-13858 and SOLR-13677 changes it should be able to use the parent
SearchComponent class one instead.
cc/fyi [~ab] and [~tflobbe]
(I first noticed the SuggestComponent thing whilst working on SOLR-14382 and
then scanning wider identified the DirectUpdateHandler2 thing.)
was (Author: cpoerschke):
Attached patch proposes these two changes:
* DirectUpdateHandler2 no longer needs to override getSolrMetricsContext: at
the time of SOLR-13866 the override was needed but subsequently SOLR-13858
removed DirectUpdateHandler2's own solrMetricsContext and added a
solrMetricsContext in the parent UpdateHandler class instead.
* SuggestComponent currently has its own metricsContext but after the
SOLR-13677 changes it should be able to use the parent SearchComponent class
one instead.
cc/fyi [~ab] and [~tflobbe]
(I first noticed the SuggestComponent thing whilst working on SOLR-14382 and
then scanning wider identified the DirectUpdateHandler2 thing.)
> two small SolrMetricsContext cleanups
> -------------------------------------
>
> Key: SOLR-14400
> URL: https://issues.apache.org/jira/browse/SOLR-14400
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-14400.patch
>
>
> (details to follow)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
