s1monw commented on a change in pull request #1389: LUCENE-9298: fix
clearDeletedDocIds in BufferedUpdates
URL: https://github.com/apache/lucene-solr/pull/1389#discussion_r406017431
##########
File path: lucene/core/src/java/org/apache/lucene/index/BufferedUpdates.java
##########
@@ -80,6 +80,7 @@ load factor (say 2 * POINTER). Entry is object w/
private final Counter bytesUsed = Counter.newCounter(true);
final Counter fieldUpdatesBytesUsed = Counter.newCounter(true);
+ private final Counter termsBytesUsed = Counter.newCounter();
Review comment:
```suggestion
private final Counter termsBytesUsed = Counter.newCounter(true);
```
Sorry I looked at it again and we have one case where we use it in a global
context in the delete queue so we need the threadsafety. Rest looks great.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
