CaoManhDat commented on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#issuecomment-610286455 @dsmiley @bruno-roustant Can you take a second look at this? I created a simple benchmark for between maps implementation (https://github.com/apache/lucene-solr/pull/1395/commits/a1be3dd08f506990b81e7aae08aa6a4ec8ec869f#diff-2cd03d050427fa8bea6ced064c32ad42). Basically it just a linear set and get from 0 to n (portion of maxSize), and here is the result. With x-axis is `n_maxSize`, and y-axis is time taken.  We can see that `dynamicMap` is much better than the worst most of time and not too worse than the best.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
