dsmiley opened a new pull request #1407: Use QueryUtils.combineQueryAndFilter more URL: https://github.com/apache/lucene-solr/pull/1407 and check query==MatchAllDocsQuery (minor & cheap optimization) I more thoroughly examined opportunities to use this new function and found them all. One or two in some spatial code I left for various reasons (e.g. deprecated code). Note that BooleanQuery.rewrite has an optimization that looks for a MatchAllDocsQuery paired with filters, thus this check here would ultimately not change the fully rewritten query that gets executed. But, it's such a cheap/easy check and BooleanQuery is a rather heavy wrapper (it's rewrite is extensive). CC @cpoerschke
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
