mikemccand commented on a change in pull request #1397: LUCENE-9304: Refactor
DWPTPool to pool DWPT directly
URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403701699
##########
File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java
##########
@@ -273,33 +269,31 @@ synchronized Closeable lockAndAbortAll() throws
IOException {
pendingNumDocs.addAndGet(-ticket.getFlushedSegment().segmentInfo.info.maxDoc());
}
});
- List<ThreadState> threadStates = new ArrayList<>();
+ List<DocumentsWriterPerThread> writer = new ArrayList<>();
AtomicBoolean released = new AtomicBoolean(false);
final Closeable release = () -> {
if (released.compareAndSet(false, true)) { // only once
if (infoStream.isEnabled("DW")) {
infoStream.message("DW", "unlockAllAbortedThread");
}
- perThreadPool.unlockNewThreadStates();
- for (ThreadState state : threadStates) {
+ perThreadPool.unlockNewWriters();
+ for (DocumentsWriterPerThread state : writer) {
Review comment:
Isn't `writer` still an empty list here? Oh I see, we are creating a lambda
and only using it below, after we've added things to `writer`, OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
