[
https://issues.apache.org/jira/browse/SOLR-14364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074975#comment-17074975
]
ASF subversion and git services commented on SOLR-14364:
--------------------------------------------------------
Commit 853621561e9a5274d93dda03978963b69b9bf6d7 in lucene-solr's branch
refs/heads/branch_8x from David Smiley
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8536215 ]
SOLR-14364: LTR SolrFeature fq improvements
Mostly general code improvements, though it should support postFilters now
Add QueryUtils.combineQueryAndFilter
(cherry picked from commit 7b3980c0804b0de16841faf16478b2b1bd217088)
> LTR SolrFeature fq improvements, like PostFilters
> -------------------------------------------------
>
> Key: SOLR-14364
> URL: https://issues.apache.org/jira/browse/SOLR-14364
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> While working on another issue, I came upon LTR's SolrFeature class which
> calls SolrIndexSearcher.getProcessedFilter – a rather low-level method that
> that nobody should call directly if they can help it. Furthermore, the way
> SolrFeature was processing the filter queries didn't support PostFilters,
> which would have been silently ignored (ouch!). After looking around this
> SolrFeature class I found multiple things to improve to reduce complexity,
> perhaps performance in some cases, and IMO improve readability. In my PR it
> has about 80 fewer lines of code now. Additionally I found it useful to add
> a new utility method combineQueryAndFilter that is useful in quite a few
> places across Solr (and my PR does so).
> I have some complaints with other things I see but want to stop here, with my
> primary objective of reducing a needless caller on getProcessedFilter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
