shalinmangar commented on a change in pull request #1382: SOLR-12720 Remove
autoReplicaFailoverWaitAfterExpiration
URL: https://github.com/apache/lucene-solr/pull/1382#discussion_r403046954
##########
File path:
solr/core/src/java/org/apache/solr/cloud/autoscaling/OverseerTriggerThread.java
##########
@@ -366,7 +366,6 @@ private AutoScalingConfig withDefaultTrigger(Map<String,
Object> triggerProps, A
}
}
// need to add
- triggerProps.computeIfPresent("waitFor", (k, v) -> (long)
(cloudConfig.getAutoReplicaFailoverWaitAfterExpiration() / 1000));
Review comment:
We need to add a default value here instead of of outright removing this
line. Use the default value which is in
`CloudConfig.DEFAULT_AUTO_REPLICA_FAILOVER_WAIT_AFTER_EXPIRATION` and set to 2
minutes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
