[
https://issues.apache.org/jira/browse/SOLR-9101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074065#comment-17074065
]
David Smiley commented on SOLR-9101:
------------------------------------
Recently my colleague [~matmarie] troubleshooted some logging problem and with
my help we found that SolrIndexSearcher.warm was clearing the SolrRequestInfo
but never re-instated a possibly pre-existing SolrRequestInfo. As I
find-usages on SolrRequestInfo.setRequestInfo, I think this problem is
common-place. I think this suggests SRI should have a better API to make doing
the right thing easy. For example maybe the SRI should be layered like a
stack. [~mkhl] I found your issue here which isn't what I suggest but is
another type of solution. I propose I file a new issue to turn it into a stack
and then close this here as wont-fix. WDYT?
BTW MDCLoggingContext.setCore/clear is similar-ish but it always keeps the
original context.
> introduce SolrRequestInfo.doInSuspension(Callable<T>). make SolrRequestInfo
> final
> ---------------------------------------------------------------------------------
>
> Key: SOLR-9101
> URL: https://issues.apache.org/jira/browse/SOLR-9101
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Mikhail Khludnev
> Priority: Major
> Attachments: SOLR-9101.patch
>
>
> During work on SOLR-8208 I fortunately hacked this. I propose changes in the
> subj which make SolrRequestInfo more powerful and protected.
> [~ysee...@gmail.com], I need your opinion regarding it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
