jpountz commented on a change in pull request #1394: LUCENE-9300: Fix field
infos update on doc values update
URL: https://github.com/apache/lucene-solr/pull/1394#discussion_r402237062
##########
File path:
lucene/core/src/test/org/apache/lucene/index/TestNumericDocValuesUpdates.java
##########
@@ -1483,6 +1484,83 @@ public void testAddIndexes() throws Exception {
IOUtils.close(dir1, dir2);
}
+ public void testUpdatesAfterAddIndexes() throws Exception {
Review comment:
It might be better to split into one unit test for the addIndexes case when
the updated field already exists in the segment, and another one for the case
when the updated field doesn't exist in the segment yet?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
