[
https://issues.apache.org/jira/browse/LUCENE-9302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073162#comment-17073162
]
Ishan Chattopadhyaya commented on LUCENE-9302:
----------------------------------------------
{quote}The in-progress patch looks good. I'm not familiar with how things work
in Solr when the client and server are on different versions or when not all
nodes of the cluster are on the same version, does the code need to be able to
handle the case when the hit count is still returned as an integer by another
node?
{quote}
Thanks for your review, Adrien. Right, need to add backcompat handling
(wondering how ugly that could be; I hope not). Also, handle the
totalGroupCount to be a long.
Shall update the patch soon.
> Integer overflow in total count in grouping results
> ---------------------------------------------------
>
> Key: LUCENE-9302
> URL: https://issues.apache.org/jira/browse/LUCENE-9302
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Ian
> Assignee: Ishan Chattopadhyaya
> Priority: Minor
> Attachments: SOLR-13004.patch, SOLR-13004.patch
>
>
> When doing a Grouping search in solr cloud you can get a negative number for
> the total found.
> This is caused by the accumulated total being held in an integer and not a
> long.
>
> example result:
> {{{ "responseHeader": { "status": 0, "QTime": 9231, "params": { "q":
> "decade:200", "indent": "true", "fl": "decade", "wt": "json", "group.field":
> "decade", "group": "true", "_": "1542773674247" } }, "grouped": { "decade": {
> "matches": -629516788, "groups": [ { "groupValue": "200", "doclist": {
> "numFound": -629516788, "start": 0, "maxScore": 1.9315376, "docs": [ {
> "decade": "200" } ] } } ] } } }}}
>
> {{result without grouping:}}
> {{{ "responseHeader": { "status": 0, "QTime": 1063, "params": { "q":
> "decade:200", "indent": "true", "fl": "decade", "wt": "json", "_":
> "1542773791855" } }, "response": { "numFound": 3665450508, "start": 0,
> "maxScore": 1.9315376, "docs": [ { "decade": "200" }, { "decade": "200" }, {
> "decade": "200" }, { "decade": "200" }, { "decade": "200" }, { "decade":
> "200" }, { "decade": "200" }, { "decade": "200" }, { "decade": "200" }, {
> "decade": "200" } ] } }}}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
