dweiss commented on issue #1390: LUCENE-9266 remove gradle wrapper jar from 
source
URL: https://github.com/apache/lucene-solr/pull/1390#issuecomment-607439907
 
 
   I would really want to limit the number of forked java processes to the 
absolute minimum in those scripts. Each invocation of java adds a bit of 
penalty to startup and these accumulate. I would assume people are running with 
Java 11+ and if it fails for them so be it... 
   
   If you really want to be nice here then I would rewrite the Downloader to be 
compatible with Java 8, then *compile* that class with javac and run it as 
regular class. The first thing you do in the downloader then is you can 
System.exit(-1) if java version < 11. 
   
   It can be also left for a separate patch/ improvement.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to