atris commented on a change in pull request #1294: LUCENE-9074: Slice
Allocation Control Plane For Concurrent Searches
URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r401565776
##########
File path: lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java
##########
@@ -70,13 +75,31 @@ public void setUp() throws Exception {
}
reader = iw.getReader();
iw.close();
+
+ Random random = random();
+ RandomIndexWriter iw2 = new RandomIndexWriter(random(), dir2,
newIndexWriterConfig().setMergePolicy(newLogMergePolicy()));
+ for (int i = 0; i < 100; i++) {
+ Document doc = new Document();
+ doc.add(newStringField("field", Integer.toString(i), Field.Store.NO));
+ doc.add(newStringField("field2", Boolean.toString(i % 2 == 0),
Field.Store.NO));
+ doc.add(new SortedDocValuesField("field2", new
BytesRef(Boolean.toString(i % 2 == 0))));
+ iw2.addDocument(doc);
+
+ if (random.nextBoolean()) {
+ iw2.commit();
+ }
+ }
+ reader2 = iw2.getReader();
+ iw2.close();
Review comment:
I did not want to touch the existing reader since it is used by many tests
-- dont see any risk though, given the specifics of the tests that use the
existing reader, should be safe. Updated, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
