HoustonPutman commented on a change in pull request #1392: SOLR-14371 Zk
StatusHandler should know about dynamic zk config
URL: https://github.com/apache/lucene-solr/pull/1392#discussion_r401045606
##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java
##########
@@ -818,6 +834,49 @@ public void downloadFromZK(String zkPath, Path dir)
throws IOException {
ZkMaintenanceUtils.downloadFromZK(this, zkPath, dir);
}
+ /**
+ * Represents one line in dynamic ZK config
+ */
+ public static class ZkConfigDyn {
+ // server.<positive id> = <address1>:<port1>:<port2>[:role];[<client port
address>:]<client port>
+ public static Pattern linePattern =
Pattern.compile("server\\.(?<serverId>\\d+) ?=
?(?<address>[^:]+):(?<leaderPort>\\d+):(?<leaderElectionPort>\\d+)(:(?<role>.*?))?(;((?<clientPortAddress>.*?):)?(?<clientPort>\\d+))?");
+ public int serverId;
Review comment:
these can all likely be final correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
