[
https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071773#comment-17071773
]
Jan Høydahl commented on SOLR-7871:
-----------------------------------
Agree.
My vision is that once we get a solr.jar with a SolrBootstrap class, we can do
pretty much anything we want in pure Java wrt startup and parsing ENV vars and
JavaOpts.
What still needs to stay in bin/solr[.cmd] is parsing solr memory settings and
other things that MUST be passed to the java cmdline.
But I hope we'll be able to kill 90% of those scripts and instead create a new
bootstrap class that can parse cmdline args, SysProps and EnvVars as well as
parse solr.in.sh or its unified replacement, and make sense of it all. Perhaps
we can even introduce some conventions, that {{SOLR_FOO_BAR}} env.var gets
converted to {{-Dsolr.foo.bar}} SysProp without any boilerplate code, except
perhaps some validation layer for fail-fast?, and thus if some component
requires {{-Dsolr.my.setting=true}}, users can add {{SOLR_MY_SETTING=true}} to
the property/yaml file instead of current practice {{SOLR_OPTS=$SOLR_OPTS
-Dsolr.my.setting=true}}.
> Platform independent config file instead of solr.in.sh and solr.in.cmd
> ----------------------------------------------------------------------
>
> Key: SOLR-7871
> URL: https://issues.apache.org/jira/browse/SOLR-7871
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
> Affects Versions: 5.2.1
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Priority: Major
> Labels: bin/solr
> Attachments: SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch
>
>
> Spinoff from SOLR-7043
> The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable
> batch files, but all they do is to set environment variables for the start
> scripts on the format {{key=value}}
> Suggest to instead have one central platform independent config file e.g.
> {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by
> {{SolrCLI.java}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
