madrob commented on issue #1165: LUCENE-9133: Fix for potential NPE in TermFilteredPresearcher#buildQuery URL: https://github.com/apache/lucene-solr/pull/1165#issuecomment-605209605 This LGTM. Can we refactor the common parts of `testQueryBuilder` and `testQueryBuilderHandlesEmptyField` so that we don't have twice as much code to maintain in the future? Something like `testQueryBuilder(boolean withEmptyField)` might be the easiest thing, but not the only solution.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
