dsmiley commented on a change in pull request #1384: Remove
CurrentCoreDescriptorProvider
URL: https://github.com/apache/lucene-solr/pull/1384#discussion_r399368319
##########
File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java
##########
@@ -287,7 +288,14 @@ public Object call() throws Exception {
}
}
- public ZkController(final CoreContainer cc, String zkServerAddress, int
zkClientConnectTimeout, CloudConfig cloudConfig, final
CurrentCoreDescriptorProvider registerOnReconnect)
+ /**
+ * @param cc Core container associated with this controller. cannot be null.
+ * @param zkServerAddress where to connect to the zk server
+ * @param zkClientConnectTimeout timeout in ms
+ * @param cloudConfig configuration for this controller. TODO: possibly
redundant with CoreContainer
+ * @param registerOnReconnect a provider of the current core descriptors.
used to know what to reregister after a reconnect
Review comment:
I wonder if "registerOnReconnect" is not appropriate for the name. It's
named how it's being used but not for what it is. Imagine how silly if all
things were named with such an approach. Perhaps simply "descriptorProvider".
Any way, leave or change as you wish.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
