dsmiley commented on a change in pull request #1310: SOLR-13350: Multithreaded 
search using collector managers
URL: https://github.com/apache/lucene-solr/pull/1310#discussion_r397827663
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
 ##########
 @@ -184,6 +184,8 @@ public CoreLoadFailure(CoreDescriptor cd, Exception 
loadFailure) {
   private volatile ExecutorService coreContainerWorkExecutor = 
ExecutorUtil.newMDCAwareCachedThreadPool(
       new DefaultSolrThreadFactory("coreContainerWorkExecutor"));
 
+  final private ExecutorService collectorExecutor;
 
 Review comment:
   nitpick: regular order is private than final.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to