[
https://issues.apache.org/jira/browse/LUCENE-9281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066017#comment-17066017
]
Uwe Schindler commented on LUCENE-9281:
---------------------------------------
I updated the PR and added the no-arg ctor to all factories. Was a bit of
annoying to do this (I remember [~tomoko] complaining when she added the
{{NAME}} string field).
While doing this I found the following at the end of each ctor:
{code:java}
if (!args.isEmpty()) {
throw new IllegalArgumentException("Unknown parameters: " + args);
}
{code}
This can be easily changed to a static method called from each ctor. We may add
a check into the source code checker.
I am also looking to add a check into the source checker like we did for the
{{NAME}} field.
Tests are currently running, lucene passed. Solr still ongoing.
> Retire SPIClassIterator from master because Java 9+ uses different mechanism
> to load services when module system is used
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-9281
> URL: https://issues.apache.org/jira/browse/LUCENE-9281
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/other
> Affects Versions: master (9.0)
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We currently have our own implementation of the service loader standard (SPI)
> fo several reasons:
> (1) In some older JDKs the order of classpath was not respected and this lead
> to wrong order of codecs implementing the same SPI name. This caused tests to
> sometimes use wrong class (we had this in Lucene 4 where we had a test-only
> read/write Lucene3 codec that was listed before the read-only one). That's no
> longer an issue, the order of loading does not matter. In addition, Java now
> does everything correct.
> (2) In Analysis, we require SPI classes to have a constructor taking args (a
> Map of params in our case). We also extract the NAME from a static field.
> Standard service loader does not support this, it tries to instantiate the
> class with default ctor.
> With Java 9+, the ServiceLoader now has a stream() method that allows to
> filter and preprocess classes:
> [https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/ServiceLoader.html#stream()]
> This allows us to use the new interface and just get the loaded class (which
> may come from module-info.class or a conventional SPI file):
> [https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/ServiceLoader.Provider.html#type()]
> This change allows us to convert Lucene to modules listing all SPIs in the
> module-info.java.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
