[ 
https://issues.apache.org/jira/browse/SOLR-14325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065922#comment-17065922
 ] 

David Smiley commented on SOLR-14325:
-------------------------------------

I briefly chatted with Yonik about this and shared my concerns.  One concern is 
that the request is asking for indexInfo yet we'd not return it sometimes 
(because I suggested passing {{false}} param to getRealtimeSearcher).  Also, 
it's debatable if realtime index info is better than non-realtime info (it's 
the difference between what hasn't been committed yet and what has).  Getting a 
realtime searcher will add overhead in common cases when there is a regular 
searcher already available.

I have an idea to conditionally not return the index info if the SolrCloud 
replica state is RECOVERING.  I will work on that.  Does that sound promising?  
There should probably be a new option since the caller may be depending on this.

[~ab] Do you know to what extent SolrCloud / metrics may depend on this extra 
information? "indexInfo" defaults to true.

> Core status could be improved to not require an IndexSearcher
> -------------------------------------------------------------
>
>                 Key: SOLR-14325
>                 URL: https://issues.apache.org/jira/browse/SOLR-14325
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Priority: Major
>         Attachments: SOLR-14325.patch, SOLR-14325.patch, SOLR-14325.patch
>
>
> When the core status is told to request "indexInfo", it currently grabs the 
> SolrIndexSearcher but only to grab the Directory.  SolrCore.getIndexSize also 
> only requires the Directory.  By insisting on a SolrIndexSearcher, we 
> potentially block for awhile if the core is in recovery since there is no 
> SolrIndexSearcher.
> [https://lists.apache.org/thread.html/r076218c964e9bd6ed0a53133be9170c3cf36cc874c1b4652120db417%40%3Cdev.lucene.apache.org%3E]
> It'd be nice to have a solution that conditionally used the Directory of the 
> SolrIndexSearcher only if it's present so that we don't waste time creating 
> one either.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to