munendrasn commented on a change in pull request #1371: SOLR-14333: print
readable version of CollapsedPostFilter query
URL: https://github.com/apache/lucene-solr/pull/1371#discussion_r396465587
##########
File path:
solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java
##########
@@ -276,7 +281,19 @@ public int getCost() {
}
public String toString(String s) {
- return s;
+ return "!collapse field=" + this.collapseField +
+ ", nullPolicy=" + getNullPolicyString(this.nullPolicy) +
+ ", groupHeadSelector=" + this.groupHeadSelector.toString() +
+ (hint == null ? "": ", hint=" + this.hint) +
+ ", size=" + this.size;
+ }
+
+ private String getNullPolicyString(int nullPolicy) {
Review comment:
check if converting them enum makes it cleaner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
