dweiss commented on a change in pull request #1364: SOLR-14335: Lock Solr's memory to prevent swapping URL: https://github.com/apache/lucene-solr/pull/1364#discussion_r396389388
########## File path: solr/bootstrap/build.gradle ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + +apply plugin: 'java-library' + +jar { + manifest { + attributes( + 'Main-Class': 'org.apache.solr.bootstrap.SolrBootstrap', + 'Class-Path': '. lib/start.jar jna.jar' Review comment: This is a chance to clean up manual jar naming, actually. The classpath here should be something like this: "Class-Path": configurations.runtimeClasspath.collect { "lib/${it.getName()}" }.join(' ')) then bootstrap would have accurate coordinates at the exact library versions it needs to launch. Plus -- the "rename" trickery wouldn't be needed anymore in server.gradle. The name of the output artifact (bootstrap.jar) can be set in this project as well (so that it doesn't have a version in the name). jar.archiveName = "boostrap.jar" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
