[ https://issues.apache.org/jira/browse/SOLR-13944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061422#comment-17061422 ]
ASF subversion and git services commented on SOLR-13944: -------------------------------------------------------- Commit 22a91af96d4aa88cfba181cc5cb324bd593426f5 in lucene-solr's branch refs/heads/branch_8x from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=22a91af ] SOLR-13944: remove redundant checks in SpellCheckCollator * After SOLR-14073, these checks become redundant and add additional tests for spellcheck with collapse > CollapsingQParserPlugin throws NPE instead of bad request > --------------------------------------------------------- > > Key: SOLR-13944 > URL: https://issues.apache.org/jira/browse/SOLR-13944 > Project: Solr > Issue Type: Bug > Affects Versions: 7.3.1 > Reporter: Stefan > Assignee: Munendra S N > Priority: Minor > Attachments: SOLR-13944.patch, SOLR-13944.patch, SOLR-13944.patch, > SOLR-13944.patch > > > I noticed the following NPE: > {code:java} > java.lang.NullPointerException at > org.apache.solr.search.CollapsingQParserPlugin$OrdFieldValueCollector.finish(CollapsingQParserPlugin.java:1021) > at > org.apache.solr.search.CollapsingQParserPlugin$OrdFieldValueCollector.finish(CollapsingQParserPlugin.java:1081) > at > org.apache.solr.search.SolrIndexSearcher.buildAndRunCollectorChain(SolrIndexSearcher.java:230) > at > org.apache.solr.search.SolrIndexSearcher.getDocListNC(SolrIndexSearcher.java:1602) > at > org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1419) > at > org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:584) > {code} > If I am correct, the problem was already addressed in SOLR-8807. The fix does > was not working in this case though, because of a syntax error in the query > (I used the local parameter syntax twice instead of combining it). The > relevant part of the query is: > {code:java} > &fq={!tag=collapser}{!collapse field=productId sort='merchantOrder asc, price > asc, id asc'} > {code} > After discussing that on the mailing list, I was asked to open a ticket, > because this situation should result in a bad request instead of a > NullpointerException (see > [https://mail-archives.apache.org/mod_mbox/lucene-solr-user/201911.mbox/%3CCAMJgJxTuSb%3D8szO8bvHiAafJOs08O_NMB4pcaHOXME4Jj-GO2A%40mail.gmail.com%3E]) -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org