dsmiley opened a new pull request #1358: SOLR-14256: replaced EMPTY with empty() to fix deadlock URL: https://github.com/apache/lucene-solr/pull/1358 The previous change has caused sporadic test failures relating to class loading race conditions. Basically an abstract base class cannot declare a static field initialized to that of a subclass. Apparently on interfaces, this is okay -- DocSet was an interface before. I had changed from an interface to abstract class before as a simplification and because I wanted to lock down the implementations to the only two that existed, and additionally many methods took a pair of DocSets and made assumptions bout the only implementations that exist. I still like that, even if I need to not have a public static final EMPTY.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
