[
https://issues.apache.org/jira/browse/SOLR-14073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058883#comment-17058883
]
Munendra S N edited comment on SOLR-14073 at 3/13/20, 4:11 PM:
---------------------------------------------------------------
[^SOLR-14073-expand.patch] (not a complete test no assertion as came up in
lesser time, ran in debug mode to check picked collapse field)
cost would control the order of execution and when it is greater than 100 it
would be executed as postFilter
My query was more related to how expand component will behave in case of
multiple collapse filters. It would be pick the only one collapse. The
question is which collapse field would be picked
{code:java}
https://github.com/apache/lucene-solr/blob/0f10b5f0424d592ed319e1b90d91f28c3a8625a9/solr/core/src/java/org/apache/solr/handler/component/ExpandComponent.java#L147
{code}
Based on this, the last collapse field is picked for expand irrespective of the
cost. Here, we can make change such that field is picked up based on cost
instead of order or maybe for trunk support expand for all collapse fields(if
possible)
I'm not sure if above things come under this issue or not, just wanted to share
my thoughts.
Thanks for fixing multiple collapse issue. Also, I'm going to resolve the
related issues, as they look similar
Sincere apologies, if I wasn't clear in the initial comment
was (Author: munendrasn):
[^SOLR-14073-expand.patch]
cost would control the order of execution and when it is greater than 100 it
would be executed as postFilter
My query was more related to how expand component will behave in case of
multiple collapse filters. It would be pick the only one collapse. The
question is which collapse field would be picked
{code:java}
https://github.com/apache/lucene-solr/blob/0f10b5f0424d592ed319e1b90d91f28c3a8625a9/solr/core/src/java/org/apache/solr/handler/component/ExpandComponent.java#L147
{code}
Based on this, the last collapse field is picked for expand irrespective of the
cost. Here, we can make change such that field is picked up based on cost
instead of order or maybe for trunk support expand for all collapse fields(if
possible)
I'm not sure if above things come under this issue or not, just wanted to share
my thoughts.
Thanks for fixing multiple collapse issue. Also, I'm going to resolve the
related issues, as they look similar
Sincere apologies, if I wasn't clear in the initial comment
> Fix segment look ahead NPE in CollapsingQParserPlugin
> -----------------------------------------------------
>
> Key: SOLR-14073
> URL: https://issues.apache.org/jira/browse/SOLR-14073
> Project: Solr
> Issue Type: Bug
> Reporter: Joel Bernstein
> Assignee: Joel Bernstein
> Priority: Major
> Fix For: 8.5
>
> Attachments: SOLR-14073-expand.patch, SOLR-14073.patch,
> SOLR-14073.patch, SOLR-14073.patch
>
>
> The CollapsingQParserPlugin has a bug that if every segment is not visited
> during the collect it throws an NPE. This causes the CollapsingQParserPlugin
> to not work when used with any feature that short circuits the segments
> during the collect. This includes using the CollapsingQParserPlugin twice in
> the same query and the time limiting collector.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
