[
https://issues.apache.org/jira/browse/LUCENE-9276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058815#comment-17058815
]
Michael McCandless commented on LUCENE-9276:
--------------------------------------------
+1, nice simplification!
I tested indexing throughput using {{luceneutil}} against trunk and saw no
measurable impact.
> Consolidate DW(PT)#updateDocument and #updateDocuments
> ------------------------------------------------------
>
> Key: LUCENE-9276
> URL: https://issues.apache.org/jira/browse/LUCENE-9276
> Project: Lucene - Core
> Issue Type: Improvement
> Affects Versions: master (9.0), 8.5
> Reporter: Simon Willnauer
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> While I was working on another IW related issue I made some changes to
> DW#updateDocument but forgot DW#updateDocuments which is annoying since the
> code is 99% identical. The same applies to DWPT#updateDocument[s]. IMO this
> is the wrong place to optimize in order to safe one or two object creations.
> Maybe we can remove this code duplication.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
