dweiss commented on a change in pull request #1319: LUCENE-9164: process all
events before closing gracefully
URL: https://github.com/apache/lucene-solr/pull/1319#discussion_r388181480
##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##########
@@ -299,7 +300,70 @@ static int getActualMaxDocs() {
final FieldNumbers globalFieldNumberMap;
final DocumentsWriter docWriter;
- private final Queue<Event> eventQueue = new ConcurrentLinkedQueue<>();
+ private final CloseableQueue eventQueue = new CloseableQueue();
Review comment:
Wouldn't it be nicer to make it just Closeable and pass IndexWriter in the
constructor (instead of each method)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
