[ 
https://issues.apache.org/jira/browse/SOLR-13942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051269#comment-17051269
 ] 

Ishan Chattopadhyaya edited comment on SOLR-13942 at 3/4/20, 2:30 PM:
----------------------------------------------------------------------

bq. Do you think that this is a sufficient test of a new API?
Ah, no! Need some meaningful asserts to validate some of the data against what 
exists in ZK. I assumed, mistakenly, that the entire ZookeeperStatusHandlerTest 
suite was added.

bq. You're missing the point: it's a separate API. It needs to be at least 
documented so that the ops people are made aware of it, know it exists and know 
how to secure it.
Sure, I'm +1 to documenting it in ref guide. But, the veto wasn't on these 
grounds, right? Or if it was, then couldn't a ref guide change been added as a 
follow up commit, without need for a veto?


was (Author: ichattopadhyaya):
bq. Do you think that this is a sufficient test of a new API?
Ah, no! Need some meaningful asserts to validate some of the data against what 
exists in ZK. I assumed, mistakenly, that the entire ZookeeperStatusHandlerTest 
suite was added.

bq. You're missing the point: it's a separate API. It needs to be at least 
documented so that the ops people are made aware of it, know it exists and know 
how to secure it.
Sure, I'm +1 to documenting it in ref guide. But, the veto wasn't on these 
grounds, right?

> /api/cluster/zk/* to fetch raw ZK data
> --------------------------------------
>
>                 Key: SOLR-13942
>                 URL: https://issues.apache.org/jira/browse/SOLR-13942
>             Project: Solr
>          Issue Type: New Feature
>          Components: v2 API
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Blocker
>             Fix For: 8.5
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> example
> download the {{state.json}} of
> {code}
> GET http://localhost:8983/api/cluster/zk/collections/gettingstarted/state.json
> {code}
> get a list of all children under {{/live_nodes}}
> {code}
> GET http://localhost:8983/api/cluster/zk/live_nodes
> {code}
> If the requested path is a node with children show the list of child nodes 
> and their meta data



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to