[
https://issues.apache.org/jira/browse/SOLR-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049938#comment-17049938
]
David Smiley commented on SOLR-10397:
-------------------------------------
I know this is an old issue, but I was looking at
{{CoreContainer.isSharedFs(CoreDescriptor)}} which was added here. It looks up
the Core to then call {{core.getDirectoryFactory().isSharedStorage()}} or
failing that (null core) it loads the config on the fly. Either path is bad
IMO; with transient/lazy cores, we don't want to potentially trigger a core
load, nor do we want to be loading configs which can potentially be expensive.
IMO the "sharedStorage" nature of a core is so important that it ought to go in
the core descriptor. WDYT?
> Port 'autoAddReplicas' feature to the autoscaling framework and make it work
> with non-shared filesystems
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-10397
> URL: https://issues.apache.org/jira/browse/SOLR-10397
> Project: Solr
> Issue Type: Sub-task
> Components: SolrCloud
> Reporter: Shalin Shekhar Mangar
> Assignee: Cao Manh Dat
> Priority: Major
> Labels: autoscaling
> Fix For: 7.1, 8.0
>
> Attachments: SOLR-10397.1.patch, SOLR-10397.2.patch,
> SOLR-10397.2.patch, SOLR-10397.2.patch, SOLR-10397.patch,
> SOLR-10397_remove_nocommit.patch
>
>
> Currently 'autoAddReplicas=true' can be specified in the Collection Create
> API to automatically add replicas when a replica becomes unavailable. I
> propose to move this feature to the autoscaling cluster policy rules design.
> This will include the following:
> * Trigger support for ‘nodeLost’ event type
> * Modification of existing implementation of ‘autoAddReplicas’ to
> automatically create the appropriate ‘nodeLost’ trigger.
> * Any such auto-created trigger must be marked internally such that setting
> ‘autoAddReplicas=false’ via the Modify Collection API should delete or
> disable corresponding trigger.
> * Support for non-HDFS filesystems while retaining the optimization afforded
> by HDFS i.e. the replaced replica can point to the existing data dir of the
> old replica.
> * Deprecate/remove the feature of enabling/disabling ‘autoAddReplicas’ across
> the entire cluster using cluster properties in favor of using the
> suspend-trigger/resume-trigger APIs.
> This will retain backward compatibility for the most part and keep a common
> use-case easy to enable as well as make it available to more people (i.e.
> people who don't use HDFS).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
