nknize commented on a change in pull request #1258: LUCENE-9225: Rectangle 
should extend LatLonGeometry
URL: https://github.com/apache/lucene-solr/pull/1258#discussion_r380385091
 
 

 ##########
 File path: 
lucene/core/src/java/org/apache/lucene/document/LatLonShapeBoundingBoxQuery.java
 ##########
 @@ -108,4 +115,385 @@ public String toString(String field) {
     sb.append(rectangle.toString());
     return sb.toString();
   }
+
+  /** Holds spatial logic for a bounding box that works in the encoded space */
+  private static class EncodedRectangle {
 
 Review comment:
   Is this class needed because `Rectangle2D` is package private?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to