[
https://issues.apache.org/jira/browse/SOLR-14258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047924#comment-17047924
]
David Smiley commented on SOLR-14258:
-------------------------------------
I've been thinking about when incompatible changes should be allowed in a minor
version. IMO, if it's possible for a plugin to be updated to work with both
versions (before & after the change), then it's okay in a minor version. WDYT
of that logic?
I don't know enough about the particular ways the plugins you've used depended
on what I changed, but do you think they might be changeable to be compatible
with the changes? For example I view the removal of HashDocSet as
straight-forward to work around; the change itself here shows how several
classes adjusted. Even though the changes here call a method that didn't exist
previously (getBits), the logic therein could be done by the plugin.
> DocList (DocSlice) should not implement DocSet
> ----------------------------------------------
>
> Key: SOLR-14258
> URL: https://issues.apache.org/jira/browse/SOLR-14258
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: master (9.0)
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> DocList is an internal interface used to hold the documents we'll ultimately
> return from search. It has one implementation -- DocSlice. It implements
> DocSet but I think that was a mistake. Basically no-where does Solr depend
> on the fact that a DocList is a DocSet today, and keeping it this way
> complicates maintenance on DocSet's abstraction.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
