dsmiley commented on a change in pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r385443497
########## File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java ########## @@ -104,7 +104,7 @@ private RestManager.Registry managedResourceRegistry; /** @see #reloadLuceneSPI() */ - private boolean needToReloadLuceneSPI = false; + private boolean needToReloadLuceneSPI = false; // requires synchronization Review comment: Yeah I did... but then I found it difficult to reason about the sequence of when it's set to true/false... vs when the actual work is done and so I instead made both methods that touch it synchronized to be clearer/safer. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
