[ https://issues.apache.org/jira/browse/LUCENE-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson resolved LUCENE-9240. ------------------------------------ Resolution: Won't Fix Never mind...... > Reorganize ./gradlew precommit tasks > ------------------------------------ > > Key: LUCENE-9240 > URL: https://issues.apache.org/jira/browse/LUCENE-9240 > Project: Lucene - Core > Issue Type: Sub-task > Reporter: Erick Erickson > Assignee: Erick Erickson > Priority: Major > > Right now we have two task groups: > *Precommit tasks* and *Verification tasks*. The precommit task is the only > task in the "Precommit tasks" group. And it runs all the tasks in > Verification tasks, right? But all these tasks live in > *./gradle/validation*... Kinda confusing. > I'm not proposing we rename the tasks themselves, just bring them into > alignment. There are several possibilities: > 1> move ./gradle/validation to ./gradle/precommit and change the group > "Verification tasks" to "Precommit tasks" > 2> rename the groups "Verification tasks" and "Precommit tasks" to > "Validation tasks", leaving the directory structure as it is. In this case, > should we rename the precommit task to "validation"? > 3> move ../gradle/validation to ./gradle/verification and change "Validation > tasks" and "Precommit tasks" to "Verification tasks". Should we change the > task name to "verification"? > 4> Choose a new name and make the appropriate changes. "prepush"? > "dothisbeforepollutiontherepowithnonsense" ;) > I don't particularly want to bikeshed about what the right name is, but now's > the time to move things around if we're going to and before doing that I'd > like some consensus before I start causing confusion. > I like <1> best, as "precommit" at least gives a clue where it should be in > the process whereas "validation" and "verification" may be more descriptive > of what it does, but don't give as much info about where it fits in the > workflow. It also won't confuse people migrating from ant, and actually does > fit in the Git world as a fine place to do this would be just before you > commit to the local repo. Especially now that it's so much faster. > We'll probably spend more time discussing that it'll take to actually do it ;) > [~tomoko] and [~dweiss] you two would probably be most inconvenienced by > moving directories around, so whatever option we settle on let me know if > there's a better time to push any changes. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org