[ 
https://issues.apache.org/jira/browse/SOLR-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039177#comment-17039177
 ] 

Lucene/Solr QA commented on SOLR-14266:
---------------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
45s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | 
{color:green}  1m 23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | 
{color:green}  1m 23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | 
{color:green}  1m 23s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 82m 
58s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 91m  0s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-14266 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12993763/SOLR-14266-01.patch |
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  
validatesourcepatterns  |
| uname | Linux lucene2-us-west.apache.org 4.4.0-170-generic #199-Ubuntu SMP 
Thu Nov 14 01:45:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
 |
| git revision | master / ce2959f |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | LTS |
|  Test Results | 
https://builds.apache.org/job/PreCommit-SOLR-Build/683/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output | 
https://builds.apache.org/job/PreCommit-SOLR-Build/683/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Fix or suppress 14 resource leak warnings in apache/solr/core
> -------------------------------------------------------------
>
>                 Key: SOLR-14266
>                 URL: https://issues.apache.org/jira/browse/SOLR-14266
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Andras Salamon
>            Priority: Minor
>         Attachments: SOLR-14266-01.patch
>
>
> There are 14 resource leak warnings inĀ {{apache/solr/common:}}
> {noformat}
> [ecj-lint] 10. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/core/CoreContainer.java
>  (at line 745)
>  [ecj-lint]     SolrFieldCacheBean fieldCacheBean = new SolrFieldCacheBean();
>  [ecj-lint]                        ^^^^^^^^^^^^^^
>  [ecj-lint] Resource leak: 'fieldCacheBean' is never closed
> --
>  [ecj-lint] 5. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/ResourceLoaderTest.java
>  (at line 215)
>  [ecj-lint]     SolrResourceLoader loader = new SolrResourceLoader();
>  [ecj-lint]                        ^^^^^^
>  [ecj-lint] Resource leak: 'loader' is never closed
> --
>  [ecj-lint] 6. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/TestLazyCores.java
>  (at line 244)
>  [ecj-lint]     MetricsHandler handler = new 
> MetricsHandler(h.getCoreContainer());
>  [ecj-lint]                    ^^^^^^^
>  [ecj-lint] Resource leak: 'handler' is never closed
> --
>  [ecj-lint] 7. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/TestLazyCores.java
>  (at line 364)
>  [ecj-lint]     final CoreAdminHandler admin = new CoreAdminHandler(cc);
>  [ecj-lint]                            ^^^^^
>  [ecj-lint] Resource leak: 'admin' is never closed
> --
>  [ecj-lint] 8. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/TestLazyCores.java
>  (at line 378)
>  [ecj-lint]     final CoreAdminHandler admin = new CoreAdminHandler(cc);
>  [ecj-lint]                            ^^^^^
>  [ecj-lint] Resource leak: 'admin' is never closed
> --
>  [ecj-lint] 9. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/TestLazyCores.java
>  (at line 638)
>  [ecj-lint]     final CoreAdminHandler admin = new CoreAdminHandler(cc);
>  [ecj-lint]                            ^^^^^
>  [ecj-lint] Resource leak: 'admin' is never closed
> --
>  [ecj-lint] 10. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java
>  (at line 32)
>  [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new 
> HdfsBackupRepository();
>  [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
>  [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed
> --
>  [ecj-lint] 11. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java
>  (at line 39)
>  [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new 
> HdfsBackupRepository();
>  [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
>  [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed
> --
>  [ecj-lint] 12. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java
>  (at line 47)
>  [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new 
> HdfsBackupRepository();
>  [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
>  [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed
> --
>  [ecj-lint] 13. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java
>  (at line 55)
>  [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new 
> HdfsBackupRepository();
>  [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
>  [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed
> --
>  [ecj-lint] 14. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java
>  (at line 63)
>  [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new 
> HdfsBackupRepository();
>  [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
>  [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed
> --
>  [ecj-lint] 15. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java
>  (at line 71)
>  [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new 
> HdfsBackupRepository();
>  [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
>  [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed
> --
>  [ecj-lint] 16. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java
>  (at line 79)
>  [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new 
> HdfsBackupRepository();
>  [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
>  [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed
> --
>  [ecj-lint] 17. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java
>  (at line 89)
>  [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new 
> HdfsBackupRepository();
>  [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
>  [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to