BiM31 commented on a change in pull request #417: Fixes SOLR-12550:
ConcurrentUpdateSolrClient doesn't respect timeouts for commits and optimize
URL: https://github.com/apache/lucene-solr/pull/417#discussion_r380719554
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClient.java
##########
@@ -121,9 +121,11 @@ protected ConcurrentUpdateSolrClient(String solrServerUrl,
protected ConcurrentUpdateSolrClient(Builder builder) {
this.internalHttpClient = (builder.httpClient == null);
- this.client = new HttpSolrClient.Builder(builder.baseSolrUrl)
- .withHttpClient(builder.httpClient)
- .build();
+ HttpSolrClient.Builder httpClientBuilder = new
HttpSolrClient.Builder(builder.baseSolrUrl)
+ .withHttpClient(builder.httpClient);
+ httpClientBuilder.connectionTimeoutMillis =
builder.connectionTimeoutMillis;
+ httpClientBuilder.socketTimeoutMillis = builder.socketTimeoutMillis;
Review comment:
Maybe you should use with* methods and do the build as the previous version.
```
.withConnectionTimeout(builder.connectionTimeoutMillis)
.withSocketTimeout(builder.socketTimeoutMillis)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
