[
https://issues.apache.org/jira/browse/LUCENE-9171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032462#comment-17032462
]
Alessandro Benedetti commented on LUCENE-9171:
----------------------------------------------
hi [~romseygeek], first of all, thank you again for your patience and very
useful insights.
I have incorporated your changes and cleaned everything up.
You find the original PR updated.
My un-resolved questions:
- boostAttribute doesn’t use BytesRef but directly float, is it a concern? We
are expected to use it at query time, so we could actually see a query time
minimal benefit in not encoding/decoding?
- you expressed concerns over SpanBoostQuery, mentioning they are sort of
broken, what should we do in that regard? right now the create span query seems
to work as expected with boosted synonyms(see the related test), I suspect if
SpanBoostQuery are broken , they should get resolved in another ticket?
- from an original comment in the test code
org.apache.solr.search.TestSolrQueryParser#testSynonymQueryStyle:
"confirm autoGeneratePhraseQueries always builds OR queries"
I changed that, was there any reason for that?
> Synonyms Boost by Payload
> -------------------------
>
> Key: LUCENE-9171
> URL: https://issues.apache.org/jira/browse/LUCENE-9171
> Project: Lucene - Core
> Issue Type: New Feature
> Components: core/queryparser
> Reporter: Alessandro Benedetti
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I have been working in the additional capability of boosting queries by terms
> payload through a parameter to enable it in Lucene Query Builder.
> This has been done targeting the Synonyms Query.
> It is parametric, so it meant to see no difference unless the feature is
> enabled.
> Solr has its bits to comply thorugh its SynonymsQueryStyles
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
