msfroh commented on a change in pull request #1155: LUCENE-8962: Add ability to
selectively merge on commit
URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r375009787
##########
File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java
##########
@@ -526,6 +526,19 @@ public abstract MergeSpecification findForcedMerges(
public abstract MergeSpecification findForcedDeletesMerges(
SegmentInfos segmentInfos, MergeContext mergeContext) throws IOException;
+ /**
+ * Identifies merges that we want to execute (synchronously) on commit. By
default, do not synchronously merge on commit.
Review comment:
Renamed in latest commit and added a new MergeTrigger.
Passing the `MergeTrigger` to the `MergeScheduler` got me thinking that it
might be possible to raise the priority of these full-flush merges, though it
would be easier to manage that in the call to `registerMerge`, which could
insert them at the front of the pending merge queue. I think that's beyond the
scope of this change, but it could make for an interesting follow-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
