msfroh commented on a change in pull request #1155: LUCENE-8962: Add ability to
selectively merge on commit
URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r374445284
##########
File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java
##########
@@ -526,6 +526,19 @@ public abstract MergeSpecification findForcedMerges(
public abstract MergeSpecification findForcedDeletesMerges(
SegmentInfos segmentInfos, MergeContext mergeContext) throws IOException;
+ /**
+ * Identifies merges that we want to execute (synchronously) on commit. By
default, do not synchronously merge on commit.
Review comment:
While updating the comments here, it occurred to me that if we want to
leverage this same method in future to trigger a merge on NRT refresh, would it
make sense to call it e.g. `findFlushMerges` or `findFullFlushMerges` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
