[
https://issues.apache.org/jira/browse/SOLR-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028486#comment-17028486
]
David Smiley commented on SOLR-10567:
-------------------------------------
+1. Looks pretty good. It's debatable if
{{org.apache.solr.schema.FieldType#getNumberType}} should be overridden by
DateRangeField to return DATE such that
{{org.apache.solr.search.facet.FacetRangeProcessor#getNumericCalc}} can rely on
that in a general way without having to test the field type with as many
instanceof checks. It's debatable because getNumberType and its enum isn't
really very well defined outside of the obvious primitive fields, yet oddly
it's defined on the base FieldType. Any way, I think think the approach here
is probably best.
> Support DateRangeField in JSON Facet API
> ----------------------------------------
>
> Key: SOLR-10567
> URL: https://issues.apache.org/jira/browse/SOLR-10567
> Project: Solr
> Issue Type: Improvement
> Components: faceting
> Affects Versions: 6.2.1
> Reporter: Stephen Weiss
> Priority: Minor
> Attachments: SOLR-10567.patch, SOLR-10567.patch
>
>
> While trying to do faceting on a daterangefield, I noticed that only the
> SimpleFacets system worked - JSON facets did not allow it. It was expecting
> any range facet to be done on a TrieField, which DateRangeField is not. I
> updated the code to simply allow DateRangeField through as well, and this
> appears to work just fine, so I'm submitting a patch so this can be included
> in the next release.
> Haven't submitted a patch before so please forgive me if I screwed up, tried
> to follow directions as best I could.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
