[
https://issues.apache.org/jira/browse/LUCENE-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026746#comment-17026746
]
Erick Erickson commented on LUCENE-9080:
----------------------------------------
[~dweiss] this comes back into HTMLCharacterEntities.jflex every time you run
the jflex target:
{code}
(' | "zwj" | "zwnj"', ')')
{code}
It's one of the little jewels I found when I was getting the ant target to run,
so I checked it in since all tests passed.
And there are another bunch of changes to HTMLStripCharFilter.java in the
generated tables, presumably because of the above?
So my guess is that it was hand-edited out. This kind of thing is why I'm
spending time getting the compiler warnings out of the javacc target.
I'll be happy to add a post-processing step to remove that if you think it's
warranted. One way or another, though, this shouldn't be a manual step.
> Upgrade ICU4j to 62.2 and make regenerate work
> ----------------------------------------------
>
> Key: LUCENE-9080
> URL: https://issues.apache.org/jira/browse/LUCENE-9080
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Erick Erickson
> Assignee: Dawid Weiss
> Priority: Major
> Fix For: master (9.0)
>
> Attachments: after_regen.patch, before_regen.patch, status.res
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The root cause is that RamUsageEstimator.NUM_BYTES_INT has been removed and
> the python scripts still reference it in the generated scripts. That part's
> easy to fix.
> Last time I looked, though, the regenerate produces some differences in the
> generated files that should be looked at to insure they're benign.
> Not really sure whether this should be a Lucene or Solr JIRA. Putting it in
> Lucene since one of the failed files is:
> lucene/core/src/java/org/apache/lucene/util/packed/Packed8ThreeBlocks.java
> I do know that one of the Solr jflex-produced file has an unexplained
> difference so it may bleed over.
> "ant regenerate" needs about 24G on my machine FWIW.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
