dsmiley commented on issue #357: [SOLR-12238] Synonym Queries boost by payload URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-579257834 I noticed the use of {{AttributeSource[]}} (array of AttributeSource), done at the behest of @romseygeek . That seems fishy... shouldn't it be a TokenStream, which is a more memory efficient iterator over AttributeSource changing state? I see, for example, the _existing_ {{createSpanQuery(TokenStream in, String field)}} but the PR adds {{newSpanQuery(String field, AttributeSource[] attributes)}} and makes the former call the latter. Why bother; why not retain createSpanQuery and if Solr wants to override it to do payload boosting then it can?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
