[
https://issues.apache.org/jira/browse/SOLR-13996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025122#comment-17025122
]
Shalin Shekhar Mangar commented on SOLR-13996:
----------------------------------------------
I've been working on a refactoring of this method and it's my fault that I
didn't see this issue and the PR earlier. However, my goals are a bit more
ambitious. This first PR https://github.com/apache/lucene-solr/pull/1220 is
just a re-organization of the code but I'll be expanding it further by adding
tests for each individual case and then move on to improve performance.
Currently this class is quite inefficient as it parses and re-parses and
creates strings out of shard urls even for solr cloud cases. The goal is to
eventually have a cloud focused class that is extremely efficient and avoids
unnecessary copies of shards/replicas completely. This will require changes in
other places as well e.g. the host checker can be made to operate in a
streaming mode etc. I haven't quite decided on how the replica list transformer
should be changed.
I hope you don't mind Ishan but I'll assign this issue and take this forward.
Reviews welcome!
> Refactor HttpShardHandler#prepDistributed() into smaller pieces
> ---------------------------------------------------------------
>
> Key: SOLR-13996
> URL: https://issues.apache.org/jira/browse/SOLR-13996
> Project: Solr
> Issue Type: Improvement
> Reporter: Ishan Chattopadhyaya
> Assignee: Shalin Shekhar Mangar
> Priority: Major
> Attachments: SOLR-13996.patch, SOLR-13996.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, it is very hard to understand all the various things being done in
> HttpShardHandler. I'm starting with refactoring the prepDistributed() method
> to make it easier to grasp. It has standalone and cloud code intertwined, and
> wanted to cleanly separate them out. Later, we can even have two separate
> method (for standalone and cloud, each).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
