dweiss commented on a change in pull request #1217: SOLR-14223 PublicKeyHandler consumes a lot of entropy during tests URL: https://github.com/apache/lucene-solr/pull/1217#discussion_r371655634
########## File path: solr/test-framework/src/java/org/apache/solr/util/NotSecurePsuedoRandom.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.util; + +import java.security.SecureRandom; +import java.security.SecureRandomSpi; +import java.util.Random; + +/** + * A mocked up instance of SecureRandom that just uses {@link Random} under the covers. + * This is to prevent blocking issues that arise in platform default + * SecureRandom instances due to too many instances / not enough random entropy. + * Tests do not need secure SSL. + */ +public class NotSecurePsuedoRandom extends SecureRandom { + public static final SecureRandom INSTANCE = new NotSecurePsuedoRandom(); + private static final Random RAND = new Random(42); Review comment: This must *not* be static or shared across test instances. A better solution would be to create this off an initial long seed and this seed should be taken from RandomizedContext.current..().random().nextLong(). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
