andyvuong commented on a change in pull request #1208: SOLR-13101: Convert
nanotime to ms
URL: https://github.com/apache/lucene-solr/pull/1208#discussion_r370891787
##########
File path:
solr/core/src/java/org/apache/solr/store/blob/metadata/CorePushPull.java
##########
@@ -499,7 +500,7 @@ void enqueueForHardDelete(BlobCoreMetadataBuilder
bcmBuilder) throws Exception {
@VisibleForTesting
protected boolean okForHardDelete(BlobCoreMetadata.BlobFileToDelete file) {
// For now we only check how long ago the file was marked for delete.
- return System.nanoTime() - file.getDeletedAt() >=
deleteManager.getDeleteDelayMs();
+ return (System.nanoTime() / 1000000) - file.getDeletedAt() >=
deleteManager.getDeleteDelayMs();
Review comment:
It might be a good idea to update the BlobFileToDelete class to make it
explicit via the javadoc (actually it doesn't have any) that the getDeletedAt()
returns the timestamp in milliseconds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
