dsmiley commented on issue #1202: SOLR-14149: CHANGES.txt Remove off-topic stuff
URL: https://github.com/apache/lucene-solr/pull/1202#issuecomment-578176920
 
 
   > this is a difference between both branches 
   
   Good; we agree.  I'll update the PR.
   
   > perhaps this should be a new checkbox in GH PR template
   
   I disagree on that because I view the audience of that template to be our 
contributors, not us committers.  I delete it as step 1 of a PR.  Notice this 
comment at the very top of the template that I added:
   _(If you are a project committer then you may remove some/all of the 
following template.)_
   
   I think it's enough for the CHANGES.txt header to refer to 
solr-upgrade-notes (in some fashion) as that is an inherent reminder that there 
are other upgrade notes.  Besides, this is really for us committers to do and 
we will form new habits.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to