[ 
https://issues.apache.org/jira/browse/LUCENE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022754#comment-17022754
 ] 

Dawid Weiss commented on LUCENE-9165:
-------------------------------------

LGTM, thanks for testing, Robert. I remember ES had some fancy way of telling 
hyperthreaded cores from physical CPUs - don't know if it's worth complicating 
the script though (those who have such fancy machines can always override in 
~/gradle.properties?).

https://github.com/elastic/elasticsearch/blob/d7ce4f203d0685f83e3480a63f264f73f0171d4e/buildSrc/src/main/java/org/elasticsearch/gradle/info/GlobalBuildInfoPlugin.java#L188-L228

> change generate-defaults.gradle not to cap testsJvms at 4
> ---------------------------------------------------------
>
>                 Key: LUCENE-9165
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9165
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Robert Muir
>            Priority: Major
>         Attachments: LUCENE-9165.patch
>
>
> {code}
>       def cpus = Runtime.runtime.availableProcessors()
>       def testsJvms = (int) Math.max(1d, Math.min(cpus * 0.5d, 4))
> {code}
> Dividing by 2 is still good (hyperthreading is still a thing), but the 
> artificial cap of 4 is a bottleneck if the hardware has more available.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to