dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#issuecomment-577499972 An interface sounds fine but it will take some steps to get to that juncture, method-by-method reducing needless scope of the very use of SRL that needn't be there. The PR is maybe 80% of the way there; close. BTW when looking over this, be sure to look commit-by-commit and not all at once since each commit is usually fairly focused. Extracting "properties" was a bit hard. getInstancePath was too but that one isn't even done.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
