[
https://issues.apache.org/jira/browse/LUCENE-9151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018625#comment-17018625
]
Erick Erickson commented on LUCENE-9151:
----------------------------------------
[~rcmuir] [~mikemccand] and maybe [~jpountz]
I'm trying to get deprecations out of lucene/queryparser for the Gradle branch
and I'm a lot confused, so can y'all hop in the wayback machine?
In LUCENE-4024 defaultMinSimilarity was deprecated in FuzzyQuery and
lucene/sandbox/src/java/org/apache/lucene/sandbox/queries/SlowFuzzyQuery.java
was added
It changed a number of references to: FuzzyQuery.defaultMinSimilarity <-
SlowFuzzyQuery.defaultMinSimilarity
In FuzzyQuery.defaultMinSimilarity the comment is: @deprecated pass integer
edit distances instead.
Additionally, FuzzyQuery.floatToEdits was added which is also deprecated,
presumably to deal with various places that had the similarity as a float (more
below).
Then LUCENE-7439 removed SlowFuzzyQuery and changed references to
SlowFuzzyQuery.defaultMinSimilarity <- FuzzyQuery.defaultMinSimilarity
Meanwhile, there's FuzzyQuery.defaultmaxedits =
LevenshteinAutomata.MAXIMUM_SUPPORTED_DISTANCE Which is apparently only used in
tests.
And then there's FuzzyConfig.java and FuzzyQueryNode.java still have a
similarity as a float and haven't been deprecated so you have to use
FuzzyQuery.floatToEdits
Originally I was going to remove the deprecated methods, but as I got into it I
realized it was a distraction from getting regenerate to work with the Gradle
build. So I'll just hack the SuppressWarnings bits into the queryparser code
like before and toss the ball into your court. I'm not demanding that anything
be done about it, just looking for any guidance you care to provide.
Plus I have no real understanding of what the right thing to do here is. As far
as the lucene/queryparser side of things, I can pretty easily just
If anyone wants to reconcile all this (perhaps in another JIRA?) I'll be happy
to help with the regenerate bits.
> Get lint and deprecation warnings out of lucene/queryparsers
> ------------------------------------------------------------
>
> Key: LUCENE-9151
> URL: https://issues.apache.org/jira/browse/LUCENE-9151
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
>
> Depends on LUCENE-9134, at least the lucene/queryparser part. I want to get
> to this while the regenerate process is fresh in my mind.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
